Fix failure when ACID table column name collides with ACID internal names

[ebyhr]

Description

Fix failure when building column metadata in Hive

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[ebyhr]

CI hit #12405

[findepi]

why removed?

[findepi]

We would probably want disallow creation of such tables

[ebyhr]

Filed #12449

[findepi]

What problem(s) is this fixing?

[ebyhr]

@findepi The below buildOrThrow() in HiveMetadata.columnMetadataGetter() threw an exception when the table contains column names in AcidSchema.ACID_COLUMN_NAMES (e.g. operation) and it's the ACID table.

        Map<String, Optional<String>> columnComment = builder.buildOrThrow();

[findepi]

@findepi The below buildOrThrow() in HiveMetadata.columnMetadataGetter() threw an exception when the table contains column names in AcidSchema.ACID_COLUMN_NAMES (e.g. operation) and it's the ACID table.

        Map<String, Optional<String>> columnComment = builder.buildOrThrow();

Thanks for explanation. This makes this change clear to me now.

Please add mention of that in the commit message

[ebyhr]

@findepi Updated the commit message.

[findepi]

pushed; updated the commit title only.

[ebyhr]

Thanks, removed my old commit title.