Skip to content

Add AccessDeniedException overloadings with extraInfo#12395

Merged
dain merged 1 commit intotrinodb:masterfrom
djsagain:david.stryker/add-access-denied-overloadings
May 17, 2022
Merged

Add AccessDeniedException overloadings with extraInfo#12395
dain merged 1 commit intotrinodb:masterfrom
djsagain:david.stryker/add-access-denied-overloadings

Conversation

@djsagain
Copy link
Member

@djsagain djsagain commented May 14, 2022

Some of the AccessDeniedException methods lack an
overloading with the extraInfo argument. This commit
adds some of those overloadings for methods where an
explanation of why access was denied is informative.

Is this change a fix, improvement, new feature, refactoring, or other?
Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
SPI: AccessDeniedException

How would you describe this change to a non-technical end user or system administrator?
Entirely upward compatible adding of methods to pass explanations when access is denied.

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

Some of the AccessDeniedException methods lack an
overloading with the extraInfo argument.  This commit
adds some of those overloadings for methods where an
explanation of why access was denied is informative.
@cla-bot cla-bot bot added the cla-signed label May 14, 2022
@djsagain djsagain requested a review from dain May 14, 2022 14:19
@findepi
Copy link
Member

findepi commented May 16, 2022

cc @kokosing @lukasz-walkiewicz

@dain dain merged commit 28ffbd7 into trinodb:master May 17, 2022
@github-actions github-actions bot added this to the 382 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants