Skip to content

Add cause exception message to JDBC query failure message #12389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dain merged 1 commit into from
May 14, 2022
Merged

Add cause exception message to JDBC query failure message #12389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ final boolean internalExecute(String sql)
throw new SQLException(e.getMessage(), e);
}
catch (RuntimeException e) {
throw new SQLException("Error executing query", e);
throw new SQLException("Error executing query: " + e.getMessage(), e);
Copy link
Copy Markdown
Member

@findepi findepi May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.getMessage() may be null
in such case, it will look funny.

Suggested change
throw new SQLException("Error executing query: " + e.getMessage(), e);
throw new SQLException("Error executing query: " + firstNonNull(e.getMessage(), e), e);

}
finally {
executingClient.set(null);
Expand Down
2 changes: 1 addition & 1 deletion service/trino-verifier/src/main/java/io/trino/verifier/Validator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ private QueryResult executeQuery(String url, String username, String password, Q
}
catch (SQLException e) {
Exception exception = e;
if (("Error executing query".equals(e.getMessage()) || "Error fetching results".equals(e.getMessage())) &&
if ((e.getMessage().startsWith("Error executing query") || "Error fetching results".equals(e.getMessage())) &&
(e.getCause() instanceof Exception)) {
exception = (Exception) e.getCause();
}
Expand Down