Skip to content

Return handle and metadata together from SPI for ANALYZE#12388

Merged
electrum merged 2 commits intotrinodb:masterfrom
electrum:analyze
Jun 12, 2022
Merged

Return handle and metadata together from SPI for ANALYZE#12388
electrum merged 2 commits intotrinodb:masterfrom
electrum:analyze

Conversation

@electrum
Copy link
Copy Markdown
Member

@electrum electrum commented May 13, 2022

Related issues, pull requests, and links

Fixes #12312

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# SPI changes

* Add new version of `getStatisticsCollectionMetadata()` to `ConnectorMetadata`
  that returns `ConnectorAnalyzeMetadata`. The existing method and
  `getTableHandleForStatisticsCollection()` method are deprecated. ({issue}`12388`)

@cla-bot cla-bot bot added the cla-signed label May 13, 2022
@electrum electrum changed the title Analyze Return handle and metadata together from SPI for ANALYZE May 13, 2022
@electrum electrum force-pushed the analyze branch 2 times, most recently from da14cc2 to 91267ee Compare May 15, 2022 19:14
@electrum electrum requested review from findepi and kasiafi May 16, 2022 16:52
@electrum electrum requested a review from martint May 25, 2022 00:06
Copy link
Copy Markdown
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@electrum electrum merged commit c293a46 into trinodb:master Jun 12, 2022
@electrum electrum deleted the analyze branch June 12, 2022 17:13
@github-actions github-actions bot added this to the 386 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Pass ConnectorTableHandle instead of ConnectorTableMetadata to ConnectorMetadata.getStatisticsCollectionMetadata

2 participants