Clean up documentation on secrets#12387
Merged
electrum merged 1 commit intotrinodb:masterfrom May 20, 2022
Merged
Conversation
Member
|
I feel like we need to be even more explicit in the sense that the env variable value can be retrieved from a secret management system on the fly as part of the startup script or by the provisioning system.. and this enables a system where no secret is stored anywhere on the Trino cluster itself and everything is just in memory of the Trino startup scripts and JVM runtime.. Check with @jefflester on user facing wording that might help |
mosabua
approved these changes
May 16, 2022
electrum
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing a few minor issues in the secrets documentation, as well as adding a sentence to clarify that environment variables can be contained within a scope.
Improvement
Docs
We're improving documentation.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: