Merged
Conversation
Member
|
Can you expand commit message and elaborate why the check is redundant? |
The reason is that condition `replace` is always 'true' when reached.
The reason is that condition `b.getClass().isArray()` is always 'true' when reached.
The reason is that the method `all` is annotated as `@NonNull`.
polaris6
force-pushed
the
remove-redundant-check
branch
from
79bd69e to
3927719
Compare
Member
Author
|
Hi @findepi, thanks for your advice, I updated the commits. |
findepi
previously approved these changes
May 16, 2022
findepi
reviewed
May 16, 2022
Member
There was a problem hiding this comment.
This used to be a dead code.
So the correct "naive update" would be to remove the block.
Is this codepath exercised?
cc @ebyhr
Member
There was a problem hiding this comment.
I think it's a dead code. Let's remove that.
Member
Author
There was a problem hiding this comment.
Thanks for your advice, I updated the commits.
Member
Author
There was a problem hiding this comment.
There is a failing check, but it's not caused by this PR and can be ignored.
polaris6
force-pushed
the
remove-redundant-check
branch
from
3927719 to
6489f1c
Compare
findepi
approved these changes
May 17, 2022
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant check
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.