Use builderWithExpectedSize when size is known#12376
Merged
sopel39 merged 1 commit intotrinodb:masterfrom May 16, 2022
Merged
Conversation
Member
|
Most of this is in engine, so cc: @sopel39 . It looks good to me however. |
sopel39
approved these changes
May 16, 2022
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
I'm not sure it matters for perf though
Member
|
mind automation |
Contributor
Author
|
@sopel39 according to javadoc builderWithExpectedSize is faster |
Contributor
Author
|
CI hit: #12413 |
wendigo
force-pushed
the
serafin/minor-improvement
branch
from
2254061 to
a548d13
Compare
wendigo
force-pushed
the
serafin/minor-improvement
branch
from
a548d13 to
e9f3d2d
Compare
Member
it is, but places where it's used might be irrelevant. |
Member
|
anyway, I think it's fine to land |
Member
|
@wendigo ping me when tests pass |
Contributor
Author
|
@sopel39 ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: