Skip to content

Fix method synchronization #12375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 2 commits into from
May 13, 2022
Merged

Fix method synchronization #12375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b5a08
Fix method synchronization
losipiuk May 13, 2022
a69a845
Remove extraneous else clauses
losipiuk May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions core/trino-main/src/main/java/io/trino/metadata/DiscoveryNodeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,9 @@ private NodeState getNodeState(InternalNode node)
if (isNodeShuttingDown(node.getNodeIdentifier())) {
return SHUTTING_DOWN;
}
else {
return ACTIVE;
}
}
else {
return INACTIVE;
return ACTIVE;
}
return INACTIVE;
}

private boolean isNodeShuttingDown(String nodeId)
Expand Down Expand Up @@ -348,7 +344,7 @@ public synchronized Set<InternalNode> getActiveConnectorNodes(CatalogName catalo
}

@Override
public NodesSnapshot getActiveNodesSnapshot()
public synchronized NodesSnapshot getActiveNodesSnapshot()
{
return new NodesSnapshot(allNodes.getActiveNodes(), activeNodesByCatalogName);
}
Expand Down