Skip to content

Clarify auto-suggestion documentation#12355

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
colebow:colebow/cli-docs
May 16, 2022
Merged

Clarify auto-suggestion documentation#12355
ebyhr merged 1 commit intotrinodb:masterfrom
colebow:colebow/cli-docs

Conversation

@colebow
Copy link
Copy Markdown
Member

@colebow colebow commented May 12, 2022

Description

Cleanup on #11671 to make sure docs are consistent & clean.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Docs

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 12, 2022
@github-actions github-actions bot added the docs label May 12, 2022
@colebow
Copy link
Copy Markdown
Member Author

colebow commented May 12, 2022

image

@colebow colebow requested review from aakashnand and mosabua May 12, 2022 15:02
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs move of section

@colebow colebow force-pushed the colebow/cli-docs branch from 867d5ef to 7fe4e61 Compare May 12, 2022 16:33
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs one clarification for non macos users.. (and in fact the macos one should be secondary)

@ebyhr ebyhr self-requested a review May 13, 2022 00:21
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label May 13, 2022
@colebow colebow force-pushed the colebow/cli-docs branch from 7fe4e61 to 8af86eb Compare May 13, 2022 15:01
@colebow colebow requested a review from mosabua May 13, 2022 15:02
@colebow colebow force-pushed the colebow/cli-docs branch from 8af86eb to 9fb3338 Compare May 16, 2022 07:36
@colebow colebow force-pushed the colebow/cli-docs branch from 9fb3338 to 0c40223 Compare May 16, 2022 07:37
@ebyhr ebyhr merged commit 01cc687 into trinodb:master May 16, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented May 16, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 381 milestone May 16, 2022
@colebow colebow deleted the colebow/cli-docs branch May 17, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed docs no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants