Enable predicate pushdown for TIMESTAMP type in Delta Lake#12344
Enable predicate pushdown for TIMESTAMP type in Delta Lake#12344ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
@MiguelWeezardo i remember you originally added these lines
the TODO went with TestSplitPruning.testTimestampPruning
the condition went with some TestDeltaLakeReadTimestamps changes
please review
There was a problem hiding this comment.
move from smoke test to Delta Connector Test. keep smoke test lightweight
ebyhr
force-pushed
the
ebi/delta-timestamp-pushdown
branch
from
e4470a9 to
653378b
Compare
There was a problem hiding this comment.
Please add entries to test handling of gaps and ambiguous values in the JVM time zone. Note that these may appear as partition values as well.
There was a problem hiding this comment.
@MiguelWeezardo Added a below entry. Please take another look.
1970-01-01 01:13:42.000 America/Bahia_Banderas
ebyhr
force-pushed
the
ebi/delta-timestamp-pushdown
branch
from
653378b to
1aed1c0
Compare
|
I was just looking back through the commit history. We added this todo before implementing #4104 and I guess I never remembered to come back and enable it for Delta. |
4 participants
Description
Documentation
(x) No documentation is needed.
Release notes
( ) Release notes entries required with the following suggested text: