Remove deprecated DML ConnectorMetadata methods#12342
Merged
losipiuk merged 13 commits intotrinodb:masterfrom May 13, 2022
Merged
Remove deprecated DML ConnectorMetadata methods#12342losipiuk merged 13 commits intotrinodb:masterfrom
losipiuk merged 13 commits intotrinodb:masterfrom
Conversation
findepi
approved these changes
May 12, 2022
hashhar
approved these changes
May 12, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % Piotr's comment. Sufficient time has passed IMO.
One suggestion I have is to maybe amend the JavaDocs for new methods to mention what to do with RetryMode (i.e. safe to ignore, how to consume it etc.).
losipiuk
force-pushed
the
lo/remove-deprecated-spi
branch
from
a4a4434 to
02d8afa
Compare
losipiuk
force-pushed
the
lo/remove-deprecated-spi
branch
from
02d8afa to
3739fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectorMetadata methods were augmented about 6 months ago with an extra
RetryModeparameter.This PR migrates remaining connectors to use non-deprecated overrides and removes deprecated ones .
Description
Cleanup
SPI
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
TODO
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: