Merged
Conversation
findinpath
reviewed
May 13, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/RetryDriver.java
Outdated
Show resolved
Hide resolved
tangjiangling
force-pushed
the
minor-code-cleanup
branch
from
21c259b to
3517625
Compare
Member
Author
|
AC @findinpath PTAL |
tangjiangling
added
the
no-release-notes
Contributor
|
nit:
The messages are more concise and there is no confusion about what they are doing. |
1 similar comment
Contributor
|
nit:
The messages are more concise and there is no confusion about what they are doing. |
findinpath
approved these changes
May 13, 2022
tangjiangling
force-pushed
the
minor-code-cleanup
branch
from
3517625 to
4cd14d5
Compare
Member
Author
|
AC |
Contributor
|
@findepi PTAL |
Member
Author
|
Ping @findepi |
The exception is never thrown by underlying code, so it doesn't need to be configured in retry driver.
This matches `RetryDriver.stopOn` configuration method.
findepi
force-pushed
the
minor-code-cleanup
branch
from
4cd14d5 to
ef36ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HiveViewNotSupportedExceptionallowedExceptionstostopOnExceptionsDescription
Code cleanup.
N/A.
N/A.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: