Fix Iceberg statistics for empty table#12316
Merged
findepi merged 5 commits intotrinodb:masterfrom May 11, 2022
Merged
Conversation
findepi
force-pushed
the
findepi/iceberg-stats-empty-table
branch
from
b3ddece to
c8f8d10
Compare
losipiuk
reviewed
May 10, 2022
Member
There was a problem hiding this comment.
nit: a constant for TableStatistics.builder() .setRowCount(Estimate.of(0)) .build();?
Member
Author
There was a problem hiding this comment.
i would call it "empty_table_statisics" but then it would look the same as TableStatistics.empty();
maybe we should rename TableStatistics.empty() in a follow-up?
losipiuk
approved these changes
May 10, 2022
alexjo2144
approved these changes
May 10, 2022
homar
approved these changes
May 10, 2022
findepi
force-pushed
the
findepi/iceberg-stats-empty-table
branch
from
c8f8d10 to
7ed8b01
Compare
Member
Author
|
(just rebased) |
This is counterpart of an already public `nativeValueToBlock`.
`computeActual` and asserting equality with `MaterializedResult` is less handy.
findepi
force-pushed
the
findepi/iceberg-stats-empty-table
branch
from
7ed8b01 to
7381fa2
Compare
Member
Author
|
Dropped |
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return correct table statistics when an Iceberg table is empty.