Properly handle failed attempts to delete a file in Hive connector

[losipiuk]

Description

Is this change a fix, improvement, new feature, refactoring, or other?

bugfix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Hive connector

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Relates to: #12306
Fixes: #12296

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Hive
* Fix an issue where leftover files could remain in the table when there was a problem when issuing delete command to underlying distributed filesystem.
  The issue could appear during call to `OPTIMIZE` table procedure or during `INSERT`/`UPDATE`/`CREATE TABLE AS` query
  executed with `retry-policy` set to `TASK` or `QUERY`. ({issue}`12314`)

[findinpath]

Can we have an integration test based on minio showcasing this fix?

https://docs.min.io/docs/minio-multi-user-quickstart-guide.html

[losipiuk]

Would be nice - but I do not have resources to do that.

[losipiuk]

Also the tricky part is that this delete call spots themselves are in error handling code paths - which would make test setup cumbersome.

[findepi]

Relates to: #12306

"Fixes"?
Also, does it "fixes" #12296 ?

[findepi]

LGTM but let's wait a bit in case ignoring delete status was deliberate. Let's give a chance for folks to chime in.

Relates to: #12306

"Fixes"?

If we want an exception - then yeah - I would say it fixes it.\

Actually no - different code path.

[losipiuk]

Relates to: #12306

"Fixes"?

If we want an exception - then yeah - I would say it fixes it.

Also, does it "fixes" #12296 ?

Yeah