Support basic auth in Prometheus#12302
Merged
ebyhr merged 3 commits intotrinodb:masterfrom May 17, 2022
Merged
Conversation
ebyhr
force-pushed
the
ebi/prometheus-basic-auth
branch
from
3bdf4c6 to
552ae9c
Compare
Praveen2112
reviewed
May 10, 2022
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
...n/resources/docker/presto-product-tests/conf/environment/multinode-all/prometheus.properties
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnectorConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusBasicAuth.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/PrometheusServer.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/prometheus-basic-auth
branch
from
552ae9c to
f4ab8dd
Compare
ebyhr
force-pushed
the
ebi/prometheus-basic-auth
branch
from
f4ab8dd to
32d9517
Compare
Member
Author
|
@Praveen2112 Updated. Please take another look when you have time. |
Praveen2112
approved these changes
May 16, 2022
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnectorConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnectorConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/prometheus-basic-auth
branch
from
32d9517 to
5fc018f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) Release notes entries required with the following suggested text: