Fix flaky failure recovery assertions#12274
Merged
losipiuk merged 1 commit intotrinodb:masterfrom May 9, 2022
Merged
Conversation
Depends on the timing of the request timeout failure injection a task might fail either with the "Encountered too many errors talking to a worker node" error message (when a failure happened to be injected before the last request to get task results) or with the "Error closing remote buffer" error message (when a failure happened to be injected after all requests getting task results have already succeeded).
This was referenced May 6, 2022
losipiuk
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on the timing of the request timeout failure injection a
task might fail either with the "Encountered too many errors talking to
a worker node" error message (when a failure happened to be injected before the
last request to get task results) or with the "Error closing remote buffer"
error message (when a failure happened to be injected after all requests
getting task results have already succeeded).
Fix
Tests
N/ARelated issues, pull requests, and links
#12151
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: