Skip to content

Allow for longer error messages in verifier query log #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
May 6, 2022
Merged

Allow for longer error messages in verifier query log #12271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/trino-verifier/src/main/java/io/trino/verifier/VerifierQueryEventDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public interface VerifierQueryEventDao
" control_teardown_query_ids_json VARCHAR(255) NULL,\n" +
" control_cpu_time_seconds DOUBLE NULL,\n" +
" control_wall_time_seconds DOUBLE NULL,\n" +
" error_message TEXT NULL,\n" +
" error_message MEDIUMTEXT NULL,\n" +
Copy link
Copy Markdown
Member

@findepi findepi May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not longtext?

Copy link
Copy Markdown
Member Author

@losipiuk losipiuk May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real reason. But 16MB should be enough for everybody ;)

" PRIMARY KEY (id),\n" +
" INDEX run_id_name_index(run_id, name)\n" +
")")
Expand Down