Skip to content

Remove HiveTableRedirectionsProvider interface#12252

Merged
findepi merged 2 commits intotrinodb:masterfrom
findinpath:hive-drop-table-redirections-provider
May 6, 2022
Merged

Remove HiveTableRedirectionsProvider interface#12252
findepi merged 2 commits intotrinodb:masterfrom
findinpath:hive-drop-table-redirections-provider

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

Description

Due to the ability of the hive connector to perform table
redirections towards both iceberg and delta-lake tables,
there is no need anymore for providing an extension point
to be able to customize the way in which table redirections
are made.

Is this change a fix, improvement, new feature, refactoring, or other?

Refactoring

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Hive connector

How would you describe this change to a non-technical end user or system administrator?

Internal refactoring change. The functionality of the trino-hive connector should stay as it is.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 5, 2022
@findinpath findinpath requested review from alexjo2144, findepi and homar May 5, 2022 08:50
@findepi findepi added maintenance Project maintenance task no-release-notes This pull request does not require release notes entry labels May 5, 2022
@findepi findepi changed the title Drop HiveTableRedirectionsProvider Remove HiveTableRedirectionsProvider interface May 5, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change commit message to

Remove `HiveTableRedirectionsProvider` interface

Due to the ability of the `hive` connector to perform table
redirections towards both `iceberg` and `delta-lake` tables,
there is no need anymore for providing an extension point
to be able to customize the way in which table redirections
are made.
@findinpath findinpath force-pushed the hive-drop-table-redirections-provider branch from 591d532 to 8beecce Compare May 5, 2022 10:59
@findinpath findinpath requested a review from findepi May 6, 2022 08:44
@findepi findepi merged commit a959fff into trinodb:master May 6, 2022
@github-actions github-actions bot added this to the 380 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants