Fix SourceDistributionTaskSource#getMoreTasks#12248
Merged
arhimondr merged 1 commit intotrinodb:masterfrom May 5, 2022
Merged
Conversation
In some cases the last task containing the last batch of splits may not have been created. This happened when the last split batch happend to return enough splits for a single task to be created, but not enough to create two full tasks and when the in a mean time the `isFinished` flag changed from `false` to `true` before the second `isFinished` check was executed.
losipiuk
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases the last task containing the last batch of splits may not
have been created.
This happened when the last split batch happend to return enough splits
for a single task to be created, but not enough to create two full tasks
and when the in a mean time the
isFinishedflag changed fromfalseto
truebefore the secondisFinishedcheck was executed.Fix
Core (fault tolerant execution)
In certain rare cases queries running with fault tolerant execution enabled could return incorrect results
Related issues, pull requests, and links
Issue: #11825
Previous (incomplete) attempt of a fix: #11870
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: