Skip to content

Rename Hive Views handling configs#12238

Merged
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/hive-views-config
May 6, 2022
Merged

Rename Hive Views handling configs#12238
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/hive-views-config

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented May 4, 2022

Introduce hive.hive-views.* config namespace.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented May 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation looks off (other places too)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, hopefully fixed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why move?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so they are next to each other

@findepi findepi force-pushed the findepi/hive-views-config branch from fd9ff8e to efc6dbc Compare May 4, 2022 11:46
Copy link
Copy Markdown
Member

@joechu1 joechu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the config hive.hive-views.legacy-translation, there is a related session property <catalog>.legacy_hive_view_translation. Would it make sense to rename to something like <catalog>.hive_views_legacy_translation? Not sure if it is a standard practice to try to follow that kind of naming convention, but seems pretty common.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented May 5, 2022

@joechu1 good point.
renamed legacy_hive_view_translation session property to hive_views_legacy_translation.

sadly, we have no backwards compatibility mechanism for session properties

@findepi findepi force-pushed the findepi/hive-views-config branch from efc6dbc to 5cde4cb Compare May 5, 2022 08:11
findepi added 2 commits May 5, 2022 13:11
Introduce `hive.hive-views.*` config namespace.
@findepi findepi force-pushed the findepi/hive-views-config branch from 5cde4cb to 42c4dc3 Compare May 5, 2022 11:11
@findepi findepi merged commit 94cc282 into trinodb:master May 6, 2022
@findepi findepi deleted the findepi/hive-views-config branch May 6, 2022 09:01
@github-actions github-actions bot added this to the 380 milestone May 6, 2022
@findepi findepi mentioned this pull request May 6, 2022
@mosabua
Copy link
Copy Markdown
Member

mosabua commented May 6, 2022

Nice work on including all the doc changes as well! Thanks @findepi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants