Fix NPE assertions on JDK17 for MemSQL negative date test#12235
Merged
findepi merged 1 commit intotrinodb:masterfrom May 6, 2022
Merged
Fix NPE assertions on JDK17 for MemSQL negative date test#12235findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
kokosing
reviewed
May 4, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/StandardColumnMappings.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-memsql-npe
branch
2 times, most recently
from
887af30 to
abd0021
Compare
Contributor
Author
|
@findepi ptal |
findepi
reviewed
May 5, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/StandardColumnMappings.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-memsql-npe
branch
from
abd0021 to
b9161cb
Compare
findepi
approved these changes
May 5, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/StandardColumnMappings.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-memsql-npe
branch
from
b9161cb to
b76bba6
Compare
ebyhr
approved these changes
May 6, 2022
findepi
approved these changes
May 6, 2022
Contributor
Author
|
Thx @findepi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK17 have more meaningfull NPE exception messages. This break assertions for negative date tests in Singlestore/MemSQL connector