Use Random instead of UUID to generate randomized prefix for echange spooling#12230
Merged
arhimondr merged 1 commit intotrinodb:masterfrom May 4, 2022
Merged
Use Random instead of UUID to generate randomized prefix for echange spooling#12230arhimondr merged 1 commit intotrinodb:masterfrom
arhimondr merged 1 commit intotrinodb:masterfrom
Conversation
Member
|
Please add a note to the commit message describing the motivation. |
linzebing
force-pushed
the
randomized-prefix
branch
4 times, most recently
from
135596d to
70b290e
Compare
arhimondr
approved these changes
May 3, 2022
...xchange-filesystem/src/main/java/io/trino/plugin/exchange/filesystem/FileSystemExchange.java
Outdated
Show resolved
Hide resolved
We want to take advantage of the 36 alphabetic/numeric chars, such that the first two chars has as many combinations as possible.
linzebing
force-pushed
the
randomized-prefix
branch
from
70b290e to
f44d0a6
Compare
findepi
reviewed
May 4, 2022
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.ThreadLocalRandom; |
Member
There was a problem hiding this comment.
from cmt msg
such that the first two chars has as many combinations as possible.
why?
Member
Author
There was a problem hiding this comment.
Ah already merged. This is mainly for S3. Users can talk to AWS to set up manual partitioning for S3 buckets, and they do that base on the first n chars. In our case, it's the first 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement
trino-exchange-filesystem
Improves the performance of randomized prefix generation.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: