Skip to content

Clarify the support for conditional column masking#12214

Merged
kokosing merged 2 commits intotrinodb:masterfrom
weiatwork:columnmaskcomment
May 13, 2022
Merged

Clarify the support for conditional column masking#12214
kokosing merged 2 commits intotrinodb:masterfrom
weiatwork:columnmaskcomment

Conversation

@weiatwork
Copy link
Copy Markdown
Contributor

Description

Is this change a fix, improvement, new feature, refactoring, or other?
Document and unit test improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
No

How would you describe this change to a non-technical end user or system administrator?
Document change

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 2, 2022
@github-actions github-actions bot added the docs label May 2, 2022
@weiatwork weiatwork requested a review from martint May 2, 2022 22:32
@weiatwork weiatwork force-pushed the columnmaskcomment branch from 5d2ad70 to 0f76c31 Compare May 2, 2022 22:42
@weiatwork weiatwork requested review from electrum and kokosing May 3, 2022 01:13
@weiatwork
Copy link
Copy Markdown
Contributor Author

@martint @kokosing Can you please review? It is a simple UT/doc PR

Copy link
Copy Markdown
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add the note to docs. I am not sure if I see the value in test either. If you feel the opposite, please remove the docs changes and I will test.

If you feel strongly about doc changes, then I guess @mosabua is a better expert than me here.

Copy link
Copy Markdown
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kokosing kokosing merged commit 4706d75 into trinodb:master May 13, 2022
@github-actions github-actions bot added this to the 381 milestone May 13, 2022
@weiatwork weiatwork deleted the columnmaskcomment branch May 13, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants