Add support and tests for OpenX JSON SerDe in Hive connector#12213
Add support and tests for OpenX JSON SerDe in Hive connector#12213anusudarsan wants to merge 2 commits intotrinodb:masterfrom
Conversation
59a167c to
72e6311
Compare
pom.xml
Outdated
There was a problem hiding this comment.
There shouldn't be any references to other repositories than maven central. Otherwise, it can be hard or problematic to build the project in environments that sit behind firewalls.
There was a problem hiding this comment.
I'm not sure if we can get rid of this dependency. The serde has shims for HDP 3 and CDH 7 (default), both of which have their own repos. I'm not sure if it will be possible to generalize it to only dependencies found on Maven Central.
There was a problem hiding this comment.
Turns out this isn't too difficult: starburstdata/hive-json-serde#6
dec5fc8 to
78639d6
Compare
0869a9f to
8215e39
Compare
ef63ca0 to
e11ce91
Compare
e11ce91 to
e0dbfb1
Compare
|
This PR fails when we remove the cloudera maven repo, and enforcer plugin has issues with a "provided" dependency. The build error message is due to a bug (missing feature) in maven-enforcer-plugin version 3.0.0 (which is the version we set in airbase). A warning in enforcer-plugin 3.0.0-M3 has been upgraded to an error in 3.0.0 and is not a configurable flag yet https://issues.apache.org/jira/browse/MENFORCER-413 |
pom.xml
Outdated
There was a problem hiding this comment.
I don’t know why we’re adding all these dependencies, but something is wrong. Is this depending on a non-shaded version of Hadoop?
There was a problem hiding this comment.
@electrum yes its not using the shaded version of hadoop. The lib uses these versions of hive/hadoop (https://github.com/starburstdata/hive-json-serde/blob/develop/pom.xml#L41). @MiguelWeezardo have we tried using the shaded version of hadoop for this?
There was a problem hiding this comment.
I haven't tried shading hadoop yet.
There was a problem hiding this comment.
starburstdata/hive-json-serde#8 - first attempt at shading, unfortunately it fails to load in Trino.
e0dbfb1 to
792a0a1
Compare
|
👋 @anusudarsan - this PR is inactive and doesn't seem to be under development. If you'd like to continue work on this at any point in the future, feel free to re-open. |
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(X) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(X) Release notes entries required with the following suggested text: