Add properties required by Datastax Cassandra java driver v4#12212
Add properties required by Datastax Cassandra java driver v4#12212ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
So thats weird... its required but it has a default value? So can I leave it out and then it will just use the default? If that is the case.. its NOT required.. .. we need to clarify this here and in the release notes text
There was a problem hiding this comment.
It has default value, but we need to enable it explicitly. We will consider changing the default value later.
There was a problem hiding this comment.
so this is NOT required then... lets remove it form the code snippet earlier
There was a problem hiding this comment.
As we talked offline, changing the default value (false → true) is also fine to me.
There was a problem hiding this comment.
At the time of this writing, we use
as the sole load balancing policy class:
should almost always be used; it requires a local datacenter to be specified either programmatically when creating the session, or via the configuration option: datastax-java-driver.basic.load-balancing-policy.local-datacenter. It can also use a highly efficient slow replica avoidance mechanism, which is by default enabled – see the option: datastax-java-driver.basic.load-balancing-policy.slow-replica-avoidance.
In the current context, I don't know whether the property cassandra.load-policy.use-dc-aware still makes sense.
mosabua
left a comment
There was a problem hiding this comment.
Needs clarification of what is actually required in docs and potentially in release notes
e778bdd to
d7a7304
Compare
d607635 to
67e90c0
Compare
After transitioning to Cassandra java driver v4, the property `cassandra.load-policy.dc-aware.local-dc` is required for the `DefaultLoadBalancingPolicy`.
67e90c0 to
c19a06b
Compare
| datacenter, defaults to ``true``. | ||
|
|
||
| ``cassandra.load-policy.dc-aware.local-dc`` The name of the local datacenter for ``DCAwareRoundRobinPolicy``. | ||
| ``cassandra.load-policy.dc-aware.local-dc`` The name of the datacenter considered "local". |
There was a problem hiding this comment.
Ideally we say this is required when use-dc-aware is true... but I am fine with the current status as well
Description
After transitioning to Cassandra java driver v4, the following properties
are required:
cassandra.load-policy.use-dc-awarecassandra.load-policy.dc-aware.local-dcDocumentation fix
Cassandra connector
This PR adds a bit more documentation for the users of
trino-cassandraafter introducing #7828Related issues, pull requests, and links
Related PR: #7828
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: