Allow skipping view materialization in BigQuery#12210
Merged
Conversation
hashhar
reviewed
May 10, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Skimmed, will revisit. Looks good generally.
| import static java.time.temporal.ChronoField.NANO_OF_SECOND; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class BigQueryQueryPageSource |
Member
There was a problem hiding this comment.
Very nice implementation having different page sources for different use-cases. This also means that at some point we can have some logic to decide when to use storage API vs query API.
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryQueryPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryTypeMapping.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-skip-view-materialization
branch
from
4ac431c to
bfedda0
Compare
hashhar
reviewed
May 12, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplit.java
Outdated
Show resolved
Hide resolved
hashhar
reviewed
May 12, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryQueryPageSource.java
Outdated
Show resolved
Hide resolved
hashhar
reviewed
May 12, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryQueryPageSource.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-skip-view-materialization
branch
from
bfedda0 to
cb38f73
Compare
hashhar
approved these changes
May 12, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow skipping view materialization in BigQuery.
Also, we can easily support other table types (e.g. MV, wildcard tables) using the new page source.
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) Release notes entries required with the following suggested text: