Remove redundant check when creating DistributedStagesScheduler#12202
Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom May 4, 2022
yikf:codeSimplification
Merged
Remove redundant check when creating DistributedStagesScheduler#12202Praveen2112 merged 1 commit intotrinodb:masterfrom yikf:codeSimplification
Praveen2112 merged 1 commit intotrinodb:masterfrom
yikf:codeSimplification
Conversation
Contributor
Author
|
cc @findepi |
Praveen2112
reviewed
May 2, 2022
Member
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
Thanks for finding it out.
@raunaqmorarka @findepi Is it okay to remove this redundant check ?
Member
There was a problem hiding this comment.
I think we rename the commit message as Remove redundant check when creating DistributedStagesScheduler
raunaqmorarka
approved these changes
May 2, 2022
yikf
changed the title
Praveen2112
changed the title
Praveen2112
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to clean useless condition in
SqlQuerySchedulerwhencreateDistributedStagesSchedulerfor code simplification(Condition 'retryPolicy == RetryPolicy.QUERY' is always 'true' when reached)Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: