Fix date column in tpcds connector#12194
Merged
arhimondr merged 1 commit intotrinodb:masterfrom May 3, 2022
Merged
Conversation
losipiuk
approved these changes
Apr 29, 2022
losipiuk
reviewed
Apr 29, 2022
findepi
approved these changes
Apr 29, 2022
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
Nice find, worth testing?
cc @sopel39 @przemekak @raunaqmorarka as benchmark datasets may need to be re-generated (or inspected for correctness).
arhimondr
force-pushed
the
fix-tpcds-date-column
branch
from
b94128f to
1a9d194
Compare
Contributor
Author
|
@findepi Added a test. Could you please take a look? |
losipiuk
reviewed
May 3, 2022
Member
There was a problem hiding this comment.
was this test failing without the fix? Worth a comment (and maybe rename) to explain what exactly are we testing here.
Contributor
Author
There was a problem hiding this comment.
I does fail without the fix. The tests are run in America/Bahia_Banderas time zone (-6). Before the change the value returned used to be 1900-01-01 while the correct value is 1900-01-02 (verified by manually checking the value TPC-DS generator returns as a string)
Will add a comment.
Number of days since epoch could be incorrect when Trino is run not in the UTC time zone as `new LocalDate(...)` returns a local date corresponding to the number of milliseconds since epoch in UTC.
arhimondr
force-pushed
the
fix-tpcds-date-column
branch
from
1a9d194 to
4f1abf0
Compare
losipiuk
approved these changes
May 3, 2022
arhimondr
added a commit
to trinodb/trino-verifier-queries
that referenced
this pull request
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Number of days since epoch could be incorrect when Trino is run not in
the UTC time zone as
new LocalDate(...)returns a local datecorresponding to the number of milliseconds since epoch in UTC.
Fix
TPC-DS connector
TPC-DSconnector tables contain incorrect values in date columns when Trino is run in a timezone other than UTCRelated issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: