Allow disabling determinism check in verifier#12193
Merged
arhimondr merged 2 commits intotrinodb:masterfrom Apr 29, 2022
Merged
Allow disabling determinism check in verifier#12193arhimondr merged 2 commits intotrinodb:masterfrom
arhimondr merged 2 commits intotrinodb:masterfrom
Conversation
losipiuk
reviewed
Apr 29, 2022
Comment on lines
-246
to
-247
| Stream<QueryResult> controlQueries = concat(Stream.of(control), validator.getControlPreQueryResults().stream(), validator.getControlPostQueryResults().stream()); | ||
| Stream<QueryResult> testQueries = concat(Stream.of(test), validator.getTestPreQueryResults().stream(), validator.getTestPostQueryResults().stream()); |
Contributor
Author
There was a problem hiding this comment.
Turns out the stream created by the Stream.concat cannot be iterated more than once.
Member
There was a problem hiding this comment.
Oh - yeah. I think this is generally true for streams.
losipiuk
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Determinism check is not needed when the query set executed is guaranteed to be deterministic.
Improvement
Verifier
N/ARelated issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: