Small verifier fixes and improvements#12181
Merged
arhimondr merged 6 commits intotrinodb:masterfrom Apr 29, 2022
Merged
Conversation
To make it easier to uncomment
When the set of queries run through verifier is fixed it is wasteful to recompute control result every run. The functionality added allows to configure verifier to store expected results in a form of a simple `SELECT * FROM VALUES ... ` Trino query.
For INSERT queries the real query is run at "pre" phase, while the main test query is merely a check sum computation. Storing the total time spent on running all test or control related queries will make it less confusing.
linzebing
approved these changes
Apr 28, 2022
losipiuk
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BIG DECIMALpreciselyMEDIUMTEXTfor columns storing queriesFix / Improvement
Verifier
N/ARelated issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: