Add Iceberg support for ALTER TABLE ... SET PROPERTIES#12161
Add Iceberg support for ALTER TABLE ... SET PROPERTIES#12161findepi merged 1 commit intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
We should allow changing partitioning, let's have a TODO+issue
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
|
Add a product test to the class |
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
ccb954b to
5c98951
Compare
I was thinking about that, but wasn't sure what exactly was testable from the Spark side. The test I added to |
f16fd6e to
30059ee
Compare
|
AC Thanks @findepi @findinpath Also added documentation |
There was a problem hiding this comment.
@mosabua mind taking a look at the doc update?
30059ee to
d1d1eca
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
d1d1eca to
246adbb
Compare
|
Thanks @findinpath, added those test cases |
246adbb to
56bb7f5
Compare
There was a problem hiding this comment.
SELECT * FROM system.metadata.table_properties where catalog_name = 'iceberg';
Do we / should we have documented somewhere this statement used to retrieve the "updatable" table properties?
There was a problem hiding this comment.
Is there a separate doc page for system tables or information_schema? I couldn't find one, but I feel like that's where it should go
There was a problem hiding this comment.
Can we please verify via
assertQuery("SELECT * FROM " + tableName, "SELECT * FROM nation");
that the change of the format_version has no negative outcome for the end user?
There was a problem hiding this comment.
Added
And no, I don't think it does
There was a problem hiding this comment.
I was just thinking that it would be good to have it in case of eventual regressions.
The two properties which can be set are `format` and `format_version`.
56bb7f5 to
4bc37bb
Compare
Description
The two properties which can be set are
formatandformat_version.New feature
Iceberg connector
Allows updating specific metadata for an Iceberg table. The format_version, and the format of the underlying data files.
Related issues, pull requests, and links
Fixes: #12138
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: