Migrate CLI Kerberos authentication#12159
Merged
electrum merged 1 commit intotrinodb:masterfrom Aug 2, 2022
Merged
Conversation
mosabua
requested changes
Apr 27, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
First round of input .. need to fix up a bunch of things
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
from
eca5a28 to
b88704f
Compare
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
from
b88704f to
3330263
Compare
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 28, 2022
Ordinant
reviewed
Jun 29, 2022
Ordinant
reviewed
Jun 29, 2022
Ordinant
reviewed
Jun 29, 2022
Member
Ordinant
left a comment
Ordinant
left a comment
There was a problem hiding this comment.
Light review, with comments left, knowing that this needs to be cut up later according to Manfred's comment.
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
5 times, most recently
from
0022088 to
a2b28c2
Compare
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
2 times, most recently
from
914a3b0 to
2f6ee45
Compare
Ordinant
reviewed
Jul 14, 2022
Ordinant
reviewed
Jul 14, 2022
Ordinant
reviewed
Jul 14, 2022
Ordinant
reviewed
Jul 14, 2022
Ordinant
reviewed
Jul 14, 2022
Member
Ordinant
left a comment
Ordinant
left a comment
There was a problem hiding this comment.
Overall, it looks great. But I still have quibbles.
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
3 times, most recently
from
7ff067b to
0b46dfd
Compare
Contributor
Author
electrum
approved these changes
Jul 29, 2022
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
from
0b46dfd to
c364a76
Compare
electrum
reviewed
Jul 29, 2022
Jessie212
force-pushed
the
jt/cli-kerberos-auth
branch
from
c364a76 to
2e55662
Compare
Member
|
Thank you @Jessie212 and @electrum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement.
Changes made to documentation only.
-Created a Kerberos authentication section in the Trino CLI page, migrated content from the CLI Kerberos authentication page to the new Trino CLI page, and deleted the CLI Kerberos authentication page.
-Cleaned up formatting.
-Fixed links.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: