Do not fail query immediately if no matching nodes available#12157
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Apr 29, 2022
Merged
Do not fail query immediately if no matching nodes available#12157losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
CI: #12151 |
arhimondr
approved these changes
Apr 28, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/BinPackingNodeAllocatorService.java
Outdated
Show resolved
Hide resolved
linzebing
approved these changes
Apr 28, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/NodeSchedulerConfig.java
Outdated
Show resolved
Hide resolved
Do not fail query immediately if there are no nodes available that match tasks' hard requirements (e.g. expose given catalog). If such a situation occurs wait for some time and only fail if we still cannot find any matching node.
losipiuk
force-pushed
the
lo/wait-if-no-nodes
branch
from
cbec9f3 to
8631b00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not fail query immediately if there are no nodes available that match tasks' hard requirements (e.g. expose given catalog).
If such a situation occurs wait for some time and only fail if we still cannot find any matching node.
fixes: #11020
improvement
core
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: