Skip to content

Disable handling of OVERRIDES_DIR / /overrides in product tests #12153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 25, 2022
Merged

Disable handling of OVERRIDES_DIR / /overrides in product tests #12153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ...er/src/main/resources/docker/presto-product-tests/common/hadoop/apply-config-overrides.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
#!/usr/bin/env bash
Copy link
Copy Markdown
Member

@kokosing kokosing Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to drop it all together?

Copy link
Copy Markdown
Contributor

@wendigo wendigo Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess to be sure that we do not have overrides in one of the base images

Copy link
Copy Markdown
Member Author

@findepi findepi Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be sure no-one tries to use mechanism that we're decomissioning.
Otherwise it could be possible that test run with a different configuration than expected.

Copy link
Copy Markdown
Member Author

@findepi findepi Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal should be a follow-up sometime later.


OVERRIDES_DIR=${OVERRIDES_DIR:-/overrides}
IFS=':' read -r -a HADOOP_OVERRIDES_DIRS <<< "${OVERRIDES_DIR}"
# test whether OVERRIDES_DIR is set
if [[ -n "${OVERRIDES_DIR+x}" ]]; then
echo "The OVERRIDES_DIR (${OVERRIDES_DIR}) support is disabled as it was deemed unused." >&2
echo "It is being removed." >&2
exit 16
fi

for overrides_dir in "${HADOOP_OVERRIDES_DIRS[@]}"
do
if test -d "${overrides_dir}"; then
echo "Applying Hadoop conf overrides from dir ${overrides_dir}"
/usr/local/bin/apply-all-site-xml-overrides "${overrides_dir}"
else
echo "Hadoop conf overrides dir ${overrides_dir} does not exist"
fi
done
if test -e /overrides; then
find /overrides >&2
echo "The /overrides handling is disabled as it was deemed unused." >&2
echo "It is being removed." >&2
exit 17
fi