Modify RowDecoder and add RedisRowDecoder#12148
Merged
ebyhr merged 1 commit intotrinodb:masterfrom May 3, 2022
Merged
Conversation
polaris6
force-pushed
the
modify-rowdecoder
branch
from
7eec051 to
552ce95
Compare
Member
Author
|
hi @findepi, I see this todo was added by you before, could you please help me to review this PR? thank you very much! |
polaris6
force-pushed
the
modify-rowdecoder
branch
from
552ce95 to
84fd3f5
Compare
Member
Author
|
hi @grantatspothero, could you please help me to review this PR? thank you very much! |
Contributor
ebyhr
reviewed
May 2, 2022
plugin/trino-redis/src/main/java/io/trino/plugin/redis/decoder/hash/HashRedisRowDecoder.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisRecordCursor.java
Show resolved
Hide resolved
This also removes `findbugs` dependency in pom.xml because it is unused.
polaris6
force-pushed
the
modify-rowdecoder
branch
from
84fd3f5 to
93ad30e
Compare
ebyhr
approved these changes
May 3, 2022
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I remove the
decodeRow(byte[] data, @Nullable Map<String, String> dataMap)function to redis module because it is Redis-specific:I remove the
com.google.code.findbugsdependency in pom.xml oftrino-record-decoderbecause it is unused:Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.