Skip to content

Update security docs for required shared secret#12129

Merged
martint merged 1 commit intotrinodb:masterfrom
simpligility:sharedsecret
Apr 27, 2022
Merged

Update security docs for required shared secret#12129
martint merged 1 commit intotrinodb:masterfrom
simpligility:sharedsecret

Conversation

@mosabua
Copy link
Member

@mosabua mosabua commented Apr 25, 2022

Description

Only a MVP of an update .. we might have to revisit for more details, but I think this is critical to get in now since it is essentially a breaking change when authentication is enabled but no shared secret it configured.

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Correction of docs.

How would you describe this change to a non-technical end user or system administrator?

Add fact that formerly optional config is now required when authentication is used.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(✅ ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(✅ ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@mosabua
Copy link
Member Author

mosabua commented Apr 26, 2022

@dain @kokosing can you please review asap so that we can get this into 379 ... users like @ckesslau are having trouble with the update to 378 and stumble into this requirement.

cc @martint

@martint martint merged commit 8513db8 into trinodb:master Apr 27, 2022
@github-actions github-actions bot added this to the 379 milestone Apr 27, 2022
@mosabua mosabua deleted the sharedsecret branch May 6, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants