Support loading of redis table description files by schedule#12123
Merged
ebyhr merged 2 commits intotrinodb:masterfrom May 11, 2022
Merged
Support loading of redis table description files by schedule#12123ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
ebyhr
reviewed
Apr 26, 2022
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorConfig.java
Outdated
Show resolved
Hide resolved
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
4 times, most recently
from
60cd24e to
a42dad0
Compare
Member
Author
|
hi @ebyhr, I fixed the conflict and resubmitted, could you please help me to merge this pr? Thank you very much! |
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
from
a42dad0 to
5033f33
Compare
Member
Author
|
hi @ebyhr, could you please help me to merge this pr? Thank you very much! |
Member
Author
|
Hi @ebyhr, I'm sorry to bother you, do I need to do something to perfect this pr? |
ebyhr
reviewed
May 9, 2022
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorConfig.java
Outdated
Show resolved
Hide resolved
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
2 times, most recently
from
5033f33 to
e05813c
Compare
ebyhr
reviewed
May 10, 2022
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
from
e05813c to
75ea4b1
Compare
ebyhr
approved these changes
May 10, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Regarding commit message of "Support dynamic loading of redis table description files"
"dynamic loading" sounds detecting the changes without waiting time. Could you reword to "Support loading Redis table description files by schedule" or something?
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
3 times, most recently
from
a55a76b to
82d35f9
Compare
polaris6
force-pushed
the
dynamic-load-redis-schema
branch
from
82d35f9 to
970202d
Compare
ebyhr
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support dynamic loading of redis table description files.
Related issues, pull requests, and links
Fixes #12240
Documentation
(x) Sufficient documentation is included in this PR.
Release notes