Ignore non delta lake tables on information_schema.columns queries#12122
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 27, 2022
Merged
Conversation
findinpath
force-pushed
the
delta-information-schema-columns-with-hive-view
branch
2 times, most recently
from
26f4220 to
a973b6b
Compare
In a shared metastore context, when dealing with non-redirected tables which are not Delta Lake tables, do not throw an exception, but instead simply ignore the table in the context of `information_schema.columns` queries. This change renders the annotation `HideNonDeltaLakeTables` useless, reason why it removes it and its usages in the code of Delta Lake connector.
findinpath
force-pushed
the
delta-information-schema-columns-with-hive-view
branch
from
a973b6b to
0eae1ca
Compare
findepi
reviewed
Apr 25, 2022
...ake/src/main/java/io/trino/plugin/deltalake/metastore/glue/DeltaLakeGlueMetastoreModule.java
Show resolved
Hide resolved
findinpath
commented
Apr 25, 2022
...-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.java
Show resolved
Hide resolved
findepi
approved these changes
Apr 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a shared metastore context, when dealing with non-redirected tables which
are not Delta Lake tables, do not throw an exception, but instead simply
ignore the table in the context of
information_schema.columnsqueries.This change renders the annotation
HideNonDeltaLakeTablesuseless,reason why it removes it and its usages in the code of Delta Lake connector.
NOTE that the setting
config.hide-non-delta-lake-tablesit is still used in the context of the classio.trino.plugin.deltalake.metastore.glue.DeltaLakeGlueMetastoreTableFilterProviderFix
Delta Lake
Consider the situation of dealing with a shared Hive metastore service where live both
deltaandhivetables and the table redirections are not enabled (delta.hive-catalog-nameis not specified).This change allows to deal without errors while performing queries on
information_schema.columnson the delta connector in the presence of Hive views/tables in the shared metastore.Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: