Skip to content

Remove wrong note about Java 17#12116

Merged
dain merged 1 commit intotrinodb:masterfrom
simpligility:intercom
Apr 25, 2022
Merged

Remove wrong note about Java 17#12116
dain merged 1 commit intotrinodb:masterfrom
simpligility:intercom

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Apr 25, 2022

Description

Internal communication works with Java 17 as well. This was fixed quite a while ago.

Is this change a fix, improvement, new feature, refactoring, or other?

Fix.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation only.

How would you describe this change to a non-technical end user or system administrator?

Correct documentation about internal communication.

Related issues, pull requests, and links

NA

Documentation

( ) No documentation is needed.
(✅ ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(✅ ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Apr 25, 2022
@mosabua mosabua requested review from dain and electrum April 25, 2022 05:14
@github-actions github-actions bot added the docs label Apr 25, 2022
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Apr 25, 2022

Question though ... does it still only work with IP addresses?

@dain
Copy link
Copy Markdown
Member

dain commented Apr 25, 2022

Question though ... does it still only work with IP addresses?

@mosabua yes. We convert the IP address to the hostname <yourIP>.ip, and then teach internal HTTP clients how to resolve that name to an ip address during DNS resolution.

@dain dain merged commit 4134035 into trinodb:master Apr 25, 2022
@github-actions github-actions bot added this to the 379 milestone Apr 25, 2022
@mosabua mosabua deleted the intercom branch April 26, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants