Make the RewriteComparision constructor more explicit#12103
Merged
hashhar merged 1 commit intotrinodb:masterfrom Apr 23, 2022
Merged
Make the RewriteComparision constructor more explicit#12103hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
A rewrite related class taking two (or more) arguments can be confusing since it suggests arg1 is rewritten to arg2 which is not the case here.
hashhar
added
the
no-release-notes
findepi
approved these changes
Apr 22, 2022
ebyhr
approved these changes
Apr 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rewrite related class taking two (or more) arguments can be confusing
since it suggests arg1 is rewritten to arg2 which is not the case here.