Skip to content

Move testCharTrailingSpace to common test class #12081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 3 commits into from
Apr 25, 2022
Merged

Move testCharTrailingSpace to common test class #12081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cdc1a7
Move testCharTrailingSpace to common test class
findepi Apr 22, 2022
6dbf95f
empty
findepi Apr 25, 2022
f833804
empty
findepi Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,19 @@ protected TestTable createTableWithUnsupportedColumn()

// TODO move common tests from connector-specific classes here

@Test
public void testCharTrailingSpace()
{
String schema = getSession().getSchema().orElseThrow();
try (TestTable table = new TestTable(onRemoteDatabase(), schema + ".char_trailing_space", "(x char(10))", List.of("'test'"))) {
String tableName = table.getName();
assertQuery("SELECT * FROM " + tableName + " WHERE x = char 'test'", "VALUES 'test'");
assertQuery("SELECT * FROM " + tableName + " WHERE x = char 'test '", "VALUES 'test'");
assertQuery("SELECT * FROM " + tableName + " WHERE x = char 'test '", "VALUES 'test'");
assertQueryReturnsEmptyResult("SELECT * FROM " + tableName + " WHERE x = char ' test'");
}
}

@Test
public void testAggregationPushdown()
{
Expand Down
8 changes: 8 additions & 0 deletions ...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,14 @@ public void testDateYearOfEraPredicate()
"Date must be between 1970-01-01 and 2106-02-07 in ClickHouse: -1996-09-14");
}

@Override
public void testCharTrailingSpace()
{
assertThatThrownBy(super::testCharTrailingSpace)
.hasMessageStartingWith("Failed to execute statement: CREATE TABLE tpch.char_trailing_space");
throw new SkipException("Implement test for ClickHouse");
}

@Override
protected SqlExecutor onRemoteDatabase()
{
Expand Down
9 changes: 9 additions & 0 deletions plugin/trino-druid/src/test/java/io/trino/plugin/druid/BaseDruidConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import static io.trino.sql.planner.assertions.PlanMatchPattern.node;
import static io.trino.testing.MaterializedResult.resultBuilder;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

public abstract class BaseDruidConnectorTest
extends BaseJdbcConnectorTest
Expand Down Expand Up @@ -291,4 +292,12 @@ public void testDateYearOfEraPredicate()
{
throw new SkipException("Druid connector does not map 'orderdate' column to date type");
}

@Override
public void testCharTrailingSpace()
{
assertThatThrownBy(super::testCharTrailingSpace)
.hasMessageContaining("Error while executing SQL \"CREATE TABLE druid.char_trailing_space");
throw new SkipException("Implement test for Druid");
}
}
15 changes: 0 additions & 15 deletions plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,21 +255,6 @@ public void testMySqlTinyint()
assertUpdate("DROP TABLE mysql_test_tinyint1");
}

@Test
public void testCharTrailingSpace()
{
onRemoteDatabase().execute("CREATE TABLE tpch.char_trailing_space (x char(10))");
assertUpdate("INSERT INTO char_trailing_space VALUES ('test')", 1);

assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test'", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");

assertEquals(getQueryRunner().execute("SELECT * FROM char_trailing_space WHERE x = char ' test'").getRowCount(), 0);

assertUpdate("DROP TABLE char_trailing_space");
}

@Override
protected String errorMessageForCreateTableAsSelectNegativeDate(String date)
{
Expand Down
8 changes: 8 additions & 0 deletions plugin/trino-phoenix/src/test/java/io/trino/plugin/phoenix/TestPhoenixConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,14 @@ public void testVarcharCharComparison()
}
}

@Override
public void testCharTrailingSpace()
{
assertThatThrownBy(super::testCharTrailingSpace)
.hasMessageContaining("The table does not have a primary key. tableName=TPCH.CHAR_TRAILING_SPACE");
throw new SkipException("Implement test for Phoenix");
}

// Overridden because Phoenix requires a ROWID column
@Override
public void testCountDistinctWithStringTypes()
Expand Down
8 changes: 8 additions & 0 deletions plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,14 @@ public void testVarcharCharComparison()
}
}

@Override
public void testCharTrailingSpace()
{
assertThatThrownBy(super::testCharTrailingSpace)
.hasMessageContaining("The table does not have a primary key. tableName=TPCH.CHAR_TRAILING_SPACE");
throw new SkipException("Implement test for Phoenix");
}

// Overridden because Phoenix requires a ROWID column
@Override
public void testCountDistinctWithStringTypes()
Expand Down
16 changes: 0 additions & 16 deletions ...rino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
import static java.util.stream.Collectors.joining;
import static java.util.stream.IntStream.range;
import static org.assertj.core.api.Assertions.assertThat;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;

Expand Down Expand Up @@ -683,21 +682,6 @@ public void testCharPredicatePushdown()
}
}

@Test
public void testCharTrailingSpace()
{
onRemoteDatabase().execute("CREATE TABLE char_trailing_space (x char(10))");
assertUpdate("INSERT INTO char_trailing_space VALUES ('test')", 1);

assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test'", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");

assertEquals(getQueryRunner().execute("SELECT * FROM char_trailing_space WHERE x = char ' test'").getRowCount(), 0);

assertUpdate("DROP TABLE char_trailing_space");
}

@Test
public void testOrPredicatePushdown()
{
Expand Down
15 changes: 0 additions & 15 deletions ...o-singlestore/src/test/java/io/trino/plugin/singlestore/TestSingleStoreConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,21 +229,6 @@ public void testSingleStoreTinyint()
assertUpdate("DROP TABLE mysql_test_tinyint1");
}

@Test
public void testCharTrailingSpace()
{
onRemoteDatabase().execute("CREATE TABLE tpch.char_trailing_space (x char(10))");
assertUpdate("INSERT INTO char_trailing_space VALUES ('test')", 1);

assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test'", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");
assertQuery("SELECT * FROM char_trailing_space WHERE x = char 'test '", "VALUES 'test'");

assertEquals(getQueryRunner().execute("SELECT * FROM char_trailing_space WHERE x = char ' test'").getRowCount(), 0);

assertUpdate("DROP TABLE char_trailing_space");
}

@Override
protected String errorMessageForInsertIntoNotNullColumn(String columnName)
{
Expand Down