Remove redundant skipTestUnlessSupportsDeletes method#12080
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 22, 2022
Merged
Conversation
findepi
added
test
maintenance
ebyhr
approved these changes
Apr 21, 2022
wendigo
approved these changes
Apr 21, 2022
findepi
force-pushed
the
findepi/remove-redundant-skiptestunlesssupportsdeletes-method-daae9c
branch
from
a3038ae to
e37d77b
Compare
hashhar
approved these changes
Apr 22, 2022
- test skipping can be simply done with `skipTestUnless(hasBehavior(SUPPORTS_DELETE));` - the correctness of SUPPORTS_DELETE declaration is already verified in `verifySupportsDeleteDeclaration` and doesn't need to be re-verified in other tests - a `skip...` method should just do a skip, not assertions, anyway
findepi
force-pushed
the
findepi/remove-redundant-skiptestunlesssupportsdeletes-method-daae9c
branch
from
e37d77b to
83e3d58
Compare
findepi
deleted the
findepi/remove-redundant-skiptestunlesssupportsdeletes-method-daae9c
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipTestUnless(hasBehavior(SUPPORTS_DELETE));verifySupportsDeleteDeclarationand doesn't need to be re-verifiedin other tests
skip...method should just do a skip, not assertions, anyway