Push disjuncts with conjuncts into PostgreSQL#12079
Merged
findepi merged 2 commits intotrinodb:masterfrom Apr 22, 2022
Merged
Conversation
wendigo
reviewed
Apr 21, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| verify(argument.getType() == BOOLEAN, "Unexpected type of OR argument: %s", argument.getType()); | |
| verify(argument.getType() == BOOLEAN, "Unexpected type of %s argument: %s", operator, argument.getType()); |
wendigo
reviewed
Apr 21, 2022
Contributor
There was a problem hiding this comment.
Instead of a class we could have a factory method on RewriteLogicalExpression
Member
Author
There was a problem hiding this comment.
i made RewriteLogicalExpression an impl detail of these classes (hence it's package private)
findepi
force-pushed
the
findepi/push-disjuncts-with-conjuncts-into-postgresql-096377
branch
from
0436841 to
2f7b12c
Compare
hashhar
approved these changes
Apr 22, 2022
wendigo
approved these changes
Apr 22, 2022
findepi
deleted the
findepi/push-disjuncts-with-conjuncts-into-postgresql-096377
branch
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.