Remove duplicate exception class#12071
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 21, 2022
Merged
Conversation
findepi
added
maintenance
The class has been copied to `AbstractTrinoCatalog` and so should have been removed from `TrinoHiveCatalog`. This may or may not fix a concurrency-related bug. `AbstractTrinoCatalog` has some generic handling for `MaterializedViewMayBeBeingRemovedException`, but since the HMS-related subclass had a copy of the exception, the handling would not kick in.
hashhar
approved these changes
Apr 21, 2022
findepi
force-pushed
the
findepi/remove-duplicate-exception-class-48c32b
branch
from
11c6667 to
79c317b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class has been copied to
AbstractTrinoCatalogand so should havebeen removed from
TrinoHiveCatalog.This may or may not fix a concurrency-related bug.
AbstractTrinoCataloghas some generic handling forMaterializedViewMayBeBeingRemovedException, but since the HMS-relatedsubclass had a copy of the exception, the handling would not kick in.