Fix code comment in Druid and base JDBC client#12066
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 22, 2022
Merged
Conversation
Member
polaris6
commented
Apr 21, 2022
polaris6
commented
hashhar
reviewed
Apr 21, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I don't think these comments are javadoc since they are useful only for the people changing the class itself - not for people using the class. i.e. it's implementation detail.
Member
|
Maybe we can convert to normal multi-line code comment instead. |
Member
Author
hi @hashhar, thank you for your suggestion. These comments contain |
ebyhr
approved these changes
Apr 22, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please capitalize the commit title and remove commit body:
Fix code comment in Druid and base JDBC client
plugin/trino-druid/src/main/java/io/trino/plugin/druid/DruidJdbcClient.java
Outdated
Show resolved
Hide resolved
polaris6
force-pushed
the
modify-the-javadoc
branch
from
f90ce07 to
4b7dc9f
Compare
Member
Author
|
hi @ebyhr, thank you for your suggestion, I resubmitted it. |
polaris6
changed the title
DruidJdbcClient
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.