Improve Tardigrade task out of memory error message#12065
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Apr 21, 2022
Merged
Improve Tardigrade task out of memory error message#12065arhimondr merged 1 commit intotrinodb:masterfrom
arhimondr merged 1 commit intotrinodb:masterfrom
Conversation
Member
|
Remove “Tardigrade” from the commit message. While that’s the name of the project to organize the development, it’s not the name of the “feature” or code modules. |
arhimondr
force-pushed
the
improve-oom-error-message
branch
from
96a5782 to
19fbd79
Compare
losipiuk
reviewed
Apr 21, 2022
Member
There was a problem hiding this comment.
Not sure if Computed next memory requirement: is not too much of an implementation detail to be part of final error message. Maybe change to Maximum possible reservation:
Contributor
Author
There was a problem hiding this comment.
It makes sense. Let me change it.
losipiuk
approved these changes
Apr 21, 2022
arhimondr
force-pushed
the
improve-oom-error-message
branch
from
19fbd79 to
2bd48cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Improvement
Core
N/ARelated issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: