Ignore final keyword in SPI backward compability test#12062
Merged
kokosing merged 1 commit intotrinodb:masterfrom Apr 21, 2022
Merged
Ignore final keyword in SPI backward compability test#12062kokosing merged 1 commit intotrinodb:masterfrom
kokosing merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
Fixes #12053 |
kokosing
force-pushed
the
origin/master/302_final
branch
from
094c3e3 to
f160145
Compare
findepi
approved these changes
Apr 21, 2022
Member
There was a problem hiding this comment.
Let's wisdom from @lukasz-stec 's #12053 (comment)
and indicate it's a conscious choice
kokosing
force-pushed
the
origin/master/302_final
branch
from
f160145 to
fe60e90
Compare
findepi
reviewed
Apr 21, 2022
core/trino-spi/src/test/java/io/trino/spi/TestSpiBackwardCompatibility.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thank you @findepi . Your wording is much better! |
kokosing
force-pushed
the
origin/master/302_final
branch
from
c618068 to
3776589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore final keyword in SPI backward compability test