Fix Delta Lake queries with predicates not expressible by tuple domain#12056
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 21, 2022
Merged
Fix Delta Lake queries with predicates not expressible by tuple domain#12056findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
findepi
reviewed
Apr 20, 2022
Member
Member
Author
There was a problem hiding this comment.
ok I will remove it. I changed it because it hurt my eyes..
Comment on lines
273
to
274
Member
There was a problem hiding this comment.
This is a discourse between code author and a reviewer. Doesn't need to be persisted in the source code comment.
However, indeed, the class is about deletes and we don't do any deletes here.
let's move it elsewhere, perhaps into BaseDeltaLakeMinioConnectorTest
Member
Author
There was a problem hiding this comment.
I wanted to avoid the discussion and leave it for future maintainers ;)
Member
There was a problem hiding this comment.
testQueryNullPartitionWithNonPushdownablePredicate + add a comment that non-pushdownable means not covertiabe to a TupleDomain
homar
force-pushed
the
homar/failed_to_generate_splits
branch
from
a687e3e to
27ab5c0
Compare
It didn't work when table was partitioned by column that contained null values and predicate was applied to it
findepi
force-pushed
the
homar/failed_to_generate_splits
branch
from
27ab5c0 to
71fbcb6
Compare
findepi
approved these changes
Apr 20, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It didn't work when table was partitioned by column that contained null values
and predicate was applied to it
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: