Skip to content

Fix running TestTableScanNodePartitioning test on single CPU nodes #12054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Apr 21, 2022
Merged

Fix running TestTableScanNodePartitioning test on single CPU nodes #12054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanNodePartitioning.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import java.util.Optional;
import java.util.function.ToIntFunction;

import static io.trino.SystemSessionProperties.TASK_CONCURRENCY;
import static io.trino.SystemSessionProperties.USE_TABLE_SCAN_NODE_PARTITIONING;
import static io.trino.spi.connector.ConnectorBucketNodeMap.createBucketNodeMap;
import static io.trino.spi.type.BigintType.BIGINT;
Expand Down Expand Up @@ -78,11 +79,13 @@ public class TestTableScanNodePartitioning
.setCatalog(MOCK_CATALOG)
.setSchema(TEST_SCHEMA)
.setSystemProperty(USE_TABLE_SCAN_NODE_PARTITIONING, "true")
.setSystemProperty(TASK_CONCURRENCY, "2") // force parallel plan even on test nodes with single CPU
.build();
public static final Session DISABLE_PLAN_WITH_TABLE_NODE_PARTITIONING = testSessionBuilder()
.setCatalog(MOCK_CATALOG)
.setSchema(TEST_SCHEMA)
.setSystemProperty(USE_TABLE_SCAN_NODE_PARTITIONING, "false")
.setSystemProperty(TASK_CONCURRENCY, "2") // force parallel plan even on test nodes with single CPU
.build();

public static final int BUCKET_COUNT = 10;
Expand Down Expand Up @@ -121,7 +124,8 @@ protected LocalQueryRunner createLocalQueryRunner()
{
Session.SessionBuilder sessionBuilder = testSessionBuilder()
.setCatalog(MOCK_CATALOG)
.setSchema(TEST_SCHEMA);
.setSchema(TEST_SCHEMA)
.setSystemProperty(TASK_CONCURRENCY, "2"); // force parallel plan even on test nodes with single CPU

LocalQueryRunner queryRunner = LocalQueryRunner.builder(sessionBuilder.build())
.withNodeCountForStats(10)
Expand Down