Fix race condition in BinPackingNodeAllocator#12048
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Apr 20, 2022
Merged
Conversation
findepi
approved these changes
Apr 20, 2022
core/trino-main/src/test/java/io/trino/execution/scheduler/TestBinPackingNodeAllocator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/scheduler/BinPackingNodeAllocatorService.java
Outdated
Show resolved
Hide resolved
Fix race condition in BinPackingNodeAllocator where BinPackingNodeLease.release() could subtract from entry in allocatedMemory map before processPendingAcquires added to this entry. With changed allocation/deallocation protocol it is no longer possible.
losipiuk
force-pushed
the
lo/fix-race-in-bin-packing-allocator
branch
from
5836171 to
bb5faf1
Compare
arhimondr
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition in BinPackingNodeAllocator where
BinPackingNodeLease.release() could subtract from entry in
allocatedMemory map before processPendingAcquires added to this entry.
With changed allocation/deallocation protocol it is no longer possible.
fix
core engine
Related issues, pull requests, and links
fixes #11876
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: